Rosen Penev <ros...@gmail.com> [2019-10-29 10:23:27]:
> My original fix was to make the code do 16 * 4 as 64 is the limit for NAPI
> weight. However this also reduces the weight for non mt7621 devices.
>
> Changed the multiplier to 2 instead.
>
> Fixes: dcdc2880b6
>
> Signed-off-by: Rosen Penev <ros...@gmail.com>
> ---
> v2: Added Fixes comment.
> .../drivers/net/ethernet/mediatek/mtk_eth_soc.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git
> a/target/linux/ramips/files-4.14/drivers/net/ethernet/mediatek/mtk_eth_soc.c
> b/target/linux/ramips/files-4.14/drivers/net/ethernet/mediatek/mtk_eth_soc.c
> index 00e84bbcfb..91974a461c 100644
> ---
> a/target/linux/ramips/files-4.14/drivers/net/ethernet/mediatek/mtk_eth_soc.c
> +++
> b/target/linux/ramips/files-4.14/drivers/net/ethernet/mediatek/mtk_eth_soc.c
> @@ -1663,11 +1663,11 @@ static int fe_probe(struct platform_device *pdev)
> INIT_WORK(&priv->pending_work, fe_pending_work);
> u64_stats_init(&priv->hw_stats->syncp);
>
> - napi_weight = 16;
> + napi_weight = 32;
> if (priv->flags & FE_FLAG_NAPI_WEIGHT) {
> - napi_weight *= 4;
> + napi_weight *= 2;
Above changes makes sense and corresponds with the commit description and with
change in commit dcdc2880b605 ("ramips: reduce napi_weight in the ethernet
driver.")
> - priv->tx_ring.tx_ring_size *= 4;
> - priv->rx_ring.rx_ring_size *= 4;
> + priv->tx_ring.tx_ring_size *= 2;
> + priv->rx_ring.rx_ring_size *= 2;
This changes don't.
-- ynezz
_______________________________________________
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel
