Hi, > -----Original Message----- > From: openwrt-devel [mailto:openwrt-devel-boun...@lists.openwrt.org] > On Behalf Of Stijn Segers > Sent: Mittwoch, 25. Dezember 2019 15:39 > To: openwrt-devel@lists.openwrt.org > Subject: [OpenWrt-Devel] [PATCH] [19.07] ramips: rename DIR-860L entries > according to the new manufacturer / device spec > > Most images follow the openwrt-target-subtarget-manufacturer-device > naming specification, but the D-Link DIR-860L rev B1 does not. This patch > brings it in line. > > Master had this updated a while ago, it's okay there.
Though I'm a big fan of unification and made an effort to have this sorted out in master, I do not think backporting those device name changes is very helpful. This will create additional work, but effectively it will just move the "break" from 19.07/master to 18.06/19.07. As a cosmetic issue, it wouldn't be a candidate for backporting under normal circumstances, too. For further reasoning/discussion, refer to the following PR in GitHub, where the same question has already been discussed a month ago: https://github.com/openwrt/openwrt/pull/2574#issuecomment-559460188 I will mark this PR as Rejected, I hope you accept my arguments and continue to submit contributions in the future. Best Adrian
openpgp-digital-signature.asc
Description: PGP signature
_______________________________________________ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
