Hello, Some follow-up thoughts, could someone clarify please?
On Sat, Dec 14, 2019 at 02:10:28AM +0300, Paul Fertser wrote: > On Fri, Dec 13, 2019 at 11:51:14PM +0100, Sven Roederer wrote: > > good point. But also on master seems to be no entry for this board in > > "01_leds". So I assume the default case fits for it. > > I looked several times through the config and was unable to see the > default case. Apparently, you count on trigger being set in DTS, and > that's ok for wlan and power, I see. It's just that I checked ar71xx > and it had those entries in uci-defaults but since triggers can be set > from DTS now that's not needed, got it. So if default trigger can be set in DTS, then it should be set there, I can see the rationale. But in this case it's not added to the system config and so repurpusing it for other tasks (or just disabling the LED) is not straight-forward anymore, as one would need to add it manually. Should a uci-defaults script be added to base-files that would populate the system config with all the LEDs present in the DT but not added by board config? -- Be free, use free (http://www.gnu.org/philosophy/free-sw.html) software! mailto:fercer...@gmail.com _______________________________________________ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
