I am strongly against this change for a simple reason. Advantage of this change is questionable, but we can get all sorts of trouble.
сб, 16 нояб. 2019 г. в 18:31, Piotr Dymacz <pep...@gmail.com>: > > Hi Adrian, > > On 08.11.2019 12:48, Adrian Schmutzler wrote: > > This patchset will introduce the label MAC address into the _default_ > > hostname and SSID of OpenWrt devices. Devices installed after these > > commits (or upgraded with sysupgrade -n) will have their hostname and > > SSID set to > > OpenWrt-ddeeff > > where "ddeeff" is the EUI of the label MAC address aa:bb:cc:dd:ee:ff. > > As this is something which touches essential system setting > (identification), I would really like other team members to join the > discussion before it sneaks in again. Especially because this was > already merged and reverted later, after short discussion on IRC. > > From my point of view, I'm only worried about all the consequences we > don't know about, so I would prefer to have this one _optional_. > > On the other hand, I'm fine with the SSID change but I see it's not > going to be that straightforward to implement. > Also, what I'm thinking about here is which one MAC should be used for > the SSID name. The 'label' one which is not available on all devices or > maybe the 'phy' one? > > > For devices where no label MAC address has been specified, hostname > > and SSIDs will use the former default "OpenWrt". > > And this is probably the biggest issue I have with the whole idea behind > 'label_mac'. As I understand the motivation, I don't like the fact it's > not specified (and probably would never be) for all devices so we will > have here inconsistency (in essential system settings!) and might end up > with confusion. Maybe that's something which should be handled by > downstream users/projects (and AFAIK, it is already). > > -- > Cheers, > Piotr > > > > > Implementing the EUI is intended to make identification of a > > particular OpenWrt device easier. The label MAC address qualifies > > for this as it is easily visible on the case and thus apparent to > > both educated and uneducated users. > > > > Adrian Schmutzler (1): > > base-files: rename SSID with EUI of mac address > > > > Rosy Song (1): > > base-files: rename hostname with EUI of mac address > > > > package/base-files/files/bin/config_generate | 16 +++++++++++++- > > .../etc/uci-defaults/15_wifi-ssid-mac-address | 22 +++++++++++++++++++ > > 2 files changed, 37 insertions(+), 1 deletion(-) > > create mode 100644 > > package/base-files/files/etc/uci-defaults/15_wifi-ssid-mac-address > > > > > _______________________________________________ > openwrt-devel mailing list > openwrt-devel@lists.openwrt.org > https://lists.openwrt.org/mailman/listinfo/openwrt-devel _______________________________________________ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel