Hi, > -----Original Message----- > From: openwrt-devel [mailto:openwrt-devel-boun...@lists.openwrt.org] On > Behalf Of Paul Fertser > Sent: Montag, 4. November 2019 22:20 > To: Adrian Schmutzler <m...@adrianschmutzler.de> > Cc: openwrt-devel@lists.openwrt.org > Subject: Re: [OpenWrt-Devel] [PATCH] ath79: add D-Link DIR-615 rev. E4 > > On Mon, Nov 04, 2019 at 05:16:15PM +0100, Adrian Schmutzler wrote: > > > + power_green: power_green { > > > + label = "d-link:green:power"; > > > > It's policy to use boardname instead of "d-link" here, except for tplink as > > far as I > know. > > But in this case there're three other boards that can be supported by > almost the same code (they lack "wlan" led but they also get a bigger > firmware partition becase they have no "lp" partition). I am not sure > how to properly add support for all of them, especially given I have > no way to test on real hardware (except for the E4).
I've just looked into ar71xx leds definitions and it seems like d-link has been used there consistently. So, ignore my comment in this context and keep your current d-link:green... Concerning adding further devices: No merge without testing on device. You can try to build a patch and then look for other people testing, either in the forum or as WIP Pull-Request. You can try to check older commits for that device to ask people for help. But without proper testing we won't accept a support patch, no matter whether it's a new device or just migrated from ar71xx. The only exception may be made when there is clear evidence on a 100 % clone of a supported device just with different name. Best Adrian
openpgp-digital-signature.asc
Description: PGP signature
_______________________________________________ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
