On 21/10/2019 21:31, David Bauer wrote:
Hello John

On 10/21/19 9:22 PM, John Crispin wrote:
On 21/10/2019 21:13, David Bauer wrote:
+config-$(call config_package,rtw88) += RTW88
+config-y += RTW88_CORE RTW88_PCI RTW88_8822BE RTW88_8822CE
+

why not put it all behind config-$(call config_package,rtw88) ? of course kbuild will 
"is not set it" if the prior is not selected but you could be explicit here. 
its bikeshedding but I was wondering if I am missing the obvious here.

Good point, i will adjust this here. It's a leftover from when i thought 
building seperate packages
for each WiFi card is a good idea (which i don't think still is).

Best wishes
David


can you resend a V2 please, i'll mark this one as superseeded in that case
        John


_______________________________________________
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Reply via email to