On Tue, 9 Apr 2019 at 14:08, Kenneth J. Miller<k...@miller.ec>  wrote:
The extroot mount preparation code for r/w rootfs overlay discovery, and
determining the user-defined /etc/config/fstab location within, would only
discover overlays residing on JFFS2 or UBIFS MTD storage.

This led to attempts at loading the uci fstab configuration without the
required /tmp/overlay directory prefix on devices with a non-MTD r/w
rootfs overlay, and thus failure to find any custom fstab /overlay extroot
entries on PREINIT.
(example: the default openwrt eMMC partition layout on the zyxel nbg6817)

Futher, with UBIFS_EXTROOT enabled (fstools package default), and no MTD
rootfs partitions present, check_extroot would not attempt rootfs
discovery on block devices, such as the ext4 mmcblk rootfs overlay on the
nbg6817.

With this patch:
1) main_extroot now attempts to load uci fstab configuration from an
    already mounted overlay, before defaulting to the prefix-less uci
    config dir when no MTD rootfs partitions are detected.
2) check_extroot now also attempts to find rootfs partitions on block
    devices when no MTD rootfs partitions are detected.

Fixes: FS#2231
Ref:https://bugs.openwrt.org/index.php?do=details&task_id=2231
Signed-off-by: Kenneth J. Miller<k...@miller.ec>
This patch makes it possible to mount extroot overlay on x86_64.

Tested-by: Val Kulkov<val.kul...@gmail.com>

Thanks for testing my patch on another platform Val.

The patch is quite small and only expands the code paths that can be taken
by extroot mount detection without removing any existing potential
conditions on raw MTD or UBI extroots, it'd be nice if it could get merged.

Any comments are appreciated.


_______________________________________________
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Reply via email to