Hi,

On 10/7/19 6:38 PM, Petr Štetiar wrote:
as discussed on IRC, this issue is caused by your custom build step[1] and
doesn't exist in the tree, so the proposed patch can be seen just a workaround
and not proper fix so I've rejected it and not going to apply.
Fine for me if the enhancements mentioned below are implemented at some point. For now the padding causes images to be unreproducible which I'd consider as a upstream problem. The `exchange_signature` step is the only way I can think of to make signed images reproducible...
This should be fixed in other places:

  < jow> to me it looks as if two distinct fixes are needed
  < jow> 1) better fwtool signature search heuristics
  < jow> 2) pad the signature before it is factored into the partition size 
calculation

1. https://gitlab.com/aparcar/rebuild/blob/master/rebuild.py#L146

-- ynezz


_______________________________________________
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Reply via email to