On Tue, Sep 24, 2019 at 7:07 PM Petr Štetiar <yn...@true.cz> wrote:
>
> Eneas Queiroz <cotequei...@gmail.com> [2019-09-24 18:28:44]:
>
> > I've got your patch applied, and it still fails make menuconfig if I
> > start from scratch or after make -C scripts/config clean. I haven't
> > tried kernel_menuconfig yet--it will have to compile a lot of stuff if
> > I start fresh.
>
> Ok, my bad, I can't read properly, you're talking about `make menuconfig` but
> I've assumed `make kernel_menuconfig` :-)
>
> So as the commit subject[1] says `build: fix make kernel_{menu,n}config ` this
> patch is about fixing only kernel_{menu,n}config targets, no desire to fix
> other broken targets.
>
> > What do you think?
>
> That it should be probably fixed in a similar manner as the other broken
> config targets, perhaps something like this would work?
>
> diff --git a/include/toplevel.mk b/include/toplevel.mk
> index 12586e87c09a..2b3b55db9f75 100644
> --- a/include/toplevel.mk
> +++ b/include/toplevel.mk
> @@ -99,6 +99,9 @@ prepare-tmpinfo: FORCE
> $(_SINGLE)$(NO_TRACE_MAKE) menuconfig $(PREP_MK); \
> fi
>
> +ifneq ($(DISTRO_PKG_CONFIG),)
> +scripts/config/mconf: export PATH:=$(dir $(DISTRO_PKG_CONFIG)):$(PATH)
> +endif
> scripts/config/mconf:
> @$(_SINGLE)$(SUBMAKE) -s -C scripts/config all CC="$(HOSTCC_WRAPPER)"
>
> Anyway, I've already deleted my testing Gentoo Docker image and don't want to
> emerge a new one in foreseeable future, so it would be nice if you could
> simply confirm, that my proposed patch[1] is ok and works, I'll merge it
> tomorrow and then you can add your fix(es) on top of that, what do you think?
>
> 1.
> https://gitlab.com/ynezz/openwrt/commit/0a20a3c08652af0d21accae6e76e8946cb4c1b84
>
> -- ynezz
I've applied both your patches ([1] plus the one inline), and tested
with all three affected targets, and they're all working now.
Tested-by: Eneas U de Queiroz <cotequei...@gmail.com>
_______________________________________________
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel
