> -----Original Message----- > From: openwrt-devel [mailto:openwrt-devel-boun...@lists.openwrt.org] On > Behalf Of Michal Cieslakiewicz > Sent: Dienstag, 13. August 2019 10:47 > To: openwrt-devel@lists.openwrt.org > Cc: Adrian Schmutzler <m...@adrianschmutzler.de> > Subject: [OpenWrt-Devel] [PATCH v4 0/5] ath79: add support for some Netgear > WNR routers > > This patchset enables ath79 target for following Netgear ar724x-based > routers currently supported by ar71xx: > * Netgear WNR1000v2 (tiny, 4_32) > * Netgear WNR2000v3 (tiny, 4_32) > * Netgear WNR2200 (generic, 8_64 + USB)
This patchset is already in good shape. It would be nice if one of the devs had
a look onto it.
Notes from my side:
- I'm not familiar with the pinmux stuff, so I have not reviewed that.
- I'm not sure whether
compatible = "qca,ar7241-eth", "syscon", "simple-mfd";
should be used to exchange initialization order as done here. (@Chuanhong Guo)
- In patch 5/5, the usb_power hog is a subnode of the ath9k node, as it is
controlled by a wireless chip pin. Is this the correct way to do it?
Best
Adrian
openpgp-digital-signature.asc
Description: PGP signature
_______________________________________________ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
