-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256
Hello, > > Same comments as before, and an additional one below. > > > +ð1 { > > + status = "okay"; > > + > > + compatible = "qca,ar7241-eth", "syscon", "simple-mfd"; > > Doesn't that disable ð1? I guess your concern is "simple-mfd"... Without it, ethX interfaces get rearranged (eth0 become eth1 and vice versa) and whole setup becomes a real mess, no network etc. I spent hours trying to find a working solution then found hint in commit: https://github.com/lede-project/source/commit/f43e8f90049fbbf7961854660c09e88fb7555ef2 It affects only ar7241-based WNRs. 7240's are fine without it. > > No chance to create additional DTSIs? > Initially I planned common DTSi for 1000v2/612v2 and 2000v3/2200, but then had second thoughts about it. It's perfectly OK for rebranded models (like 612v2 and on150r), but here we split device configuration between two or more files with IMHO very little gain - LED and key config is completely different for each WNR device yet it consumes most text space. So I would prefer to keep each WNR* router in separate DTS for clarity sake, I hope it is OK for you. Should I reply with v4 patches here or create new v4 thread ? Best regards Michal -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEi7ylFMzTSbpOuOZIHU8//LdGKWsFAl1RffgACgkQHU8//LdG KWvJMRAAnwKfdFXQgyvSXHZCBaE3QHkrinSyDAbfveerEehFNtkm2Sr+ZfAyKCMu dl8+t0/fMXYJrKTxkCn5gwhPGHHlymsBQoF8GQLFxQuakrzzWUde3jl6F1EuZg8l HjacPCQpFgkCdqePNl7Io/A63agAZ3uPjBbT05a+AJWgxPVCmyc1n16I9lp0fZpJ R0mErddFLrkxJd/qPto1qtIt0kP78W4WGMftSd0/vKbh+33TRy/fVFRS2CtzFUzY hKADxbZ1rm7JGH2k8QfXZdvAaEjcy+tqDx4wG0FDfpUcVkR0SMRoD7LCC0LTXHAC kiw/iPZM0nuS4eP3NieTwRbRHgXjpFMEmuPIRcgfJt4BIcmzMI7wXxd7MvSGgEXP Q6/v98DHl6+/G6Mkv53WmqKAmUSfnuXGXum5QypwxEGLZrFNfQR8aszhV+GcxWAh MiDet2mFnIglDqyJ8ArPeibi0ZFMV7xdHRHCBnbEWuE+wDpyryUAcOO36+3+qELL ulNl53y7TwgqBVQEBseYweD/TPUsSQ+6GNKH+nTDdlbcj75Vs80762uu9TC225xP Ql+wVdGBuqDxLP15qxm5bJGl7zuaK5rw6d0kgjBEehsIv4CQa+1o69iF3SbCwDfi ZU7dfMmI5j27xM95Nm8KajOBWAEyn8QYEhRgoa8OgNXjAjMAtNM= =j7WW -----END PGP SIGNATURE----- _______________________________________________ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel