From: Rafał Miłecki <ra...@milecki.pl> This parser's matching function appears to be too generic as it matches e.g. Buffalo WZR-HP-G300NH. That results in incorrect parts parsing.
Luckily this parser is needed by Fon FON2601 only which uses DT-based ramips target. It means we can depend on mtd subsystem matching of "fonfxc,uimage" string. That said triggering this parser based on the "firmware" (or whatever MTD_SPLIT_FIRMWARE_NAME is) partiiton name is not needed. It can be dropped which will automatically fix the Buffalo WZR-HP-G300NH case. Fixes: a1c6a316d299 ("ramips: add support for Fon FON2601") Signed-off-by: Rafał Miłecki <ra...@milecki.pl> --- .../linux/generic/files/drivers/mtd/mtdsplit/mtdsplit_uimage.c | 1 - 1 file changed, 1 deletion(-) diff --git a/target/linux/generic/files/drivers/mtd/mtdsplit/mtdsplit_uimage.c b/target/linux/generic/files/drivers/mtd/mtdsplit/mtdsplit_uimage.c index 091403ae91..41347d0419 100644 --- a/target/linux/generic/files/drivers/mtd/mtdsplit/mtdsplit_uimage.c +++ b/target/linux/generic/files/drivers/mtd/mtdsplit/mtdsplit_uimage.c @@ -421,7 +421,6 @@ static struct mtd_part_parser uimage_fonfxc_parser = { .of_match_table = mtdsplit_uimage_fonfxc_of_match_table, #endif .parse_fn = mtdsplit_uimage_parse_fonfxc, - .type = MTD_PARSER_TYPE_FIRMWARE, }; /************************************************** -- 2.21.0 _______________________________________________ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel