Hi, > -----Original Message----- > From: Petr Štetiar [mailto:yn...@true.cz] > Sent: Donnerstag, 9. Mai 2019 14:42 > To: Adrian Schmutzler <freif...@adrianschmutzler.de> > Cc: openwrt-devel@lists.openwrt.org > Subject: Re: [OpenWrt-Devel] [PATCH] ath79: Add missing read-only properties > > Adrian Schmutzler <freif...@adrianschmutzler.de> [2019-05-09 13:50:39]: > > Hi, > > > The read-only properties for non-firmware partitions seem to have been > > assigned rather randomly. > > Instead of randomly I would say, that it was developer/submitter preference. > > > label = "u-boot-env"; > > + read-only; > > }; > > as ath79 has `DEFAULT_PACKAGES += uboot-envtools` and just few devices set > `DEFAULT_PACKAGES -= uboot-envtools` I would assume, that it's expected to > be > writeable.
Okay. I also found some devices where u-boot-env IS read-only, e.g. https://github.com/openwrt/openwrt/blob/master/target/linux/ath79/dts/ar7240_buffalo_whr-g301n.dts#L131 What would you suggest: 1. Remove read-only from the remaining ones 2. Set it based on how DEFAULT_PACKAGES is set 3. Don't change. Leave it as it was set by the submitters In case 1 or 2, I would separate this from the other changes into a separate patch. Best Adrian > > > label = "art"; > > + read-only; > > }; > > this one seems legit and should be probably ok. > > -- ynezz
pgpxTasBd4YOu.pgp
Description: PGP signature
_______________________________________________ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
