Here is a new set of firmware images. This hopefully fixes another rate-ctrl
crash,
and fixes at least the obvious bug with 4-addr vlans. If you can, please make
a patch
and submit this upstream to OpenWRT:
9980
e3876b50cbd095f406a5d8eff310148bbef51ddc07d37af51494e35e9a19590d
firmware-5-ct-full-community-12.bin-lede.004
59c67a9707fe5c3c632cc19f4b35814abe948dc07274e9aa1095a4e838840388
firmware-5-ct-full-htt-mgt-community-12.bin-lede.004
/home/greearb/candela_html/downloads
9984
96fc12fc46f8520d2f36a081058e214325037313ae48afe245101466e027b6b0
firmware-5-ct-full-community-12.bin-lede.004
7f1211c64b52ab59fc2efb39e7a279847e426de96eeff1e017becea8663f798d
firmware-5-ct-full-htt-mgt-community-12.bin-lede.004
/home/greearb/candela_html/downloads
4019
47fc0409b9766cce3718342ea8d272f0153459450bc1833d44a72a1884e81f11
firmware-5-ct-full-community-12.bin-lede.004
fb376ccde84b9a013aafc4ab2db573d0e982ae398aa647042c6f917559293a3a
firmware-5-ct-full-htt-mgt-community-12.bin-lede.004
/home/greearb/candela_html/downloads
9888
beb4e2973330c7640e036500f8d2c68fc428a9b2266a077aebb8e8e798eca75c
firmware-5-ct-full-community-12.bin-lede.004
15fa57f6c5752877d7c96a05d2301f7eccd01832bc07d15d33246b8c06890d4c
firmware-5-ct-full-htt-mgt-community-12.bin-lede.004
Release notes since last time:
* Feb 8, 2019: Fix rate-ctrl assert related to bad logic that tried to
guess that lower bandwidth probes
were automatically successful if higher was. The NSS
mismatch that can happen here caused
the assert. Just comment out the offending code (per
comment from original QCA code).
This is bug 69.
* Feb 10, 2019: Fix bssid mis-alignment that broke 4-addr vlan mode (bug
67). Original buggy commit
was commit 2bf89e70ecd1eaf8d1c70df7d32f99d1e1c47fe3
dev-ds: Better packing of wal_vdev struct.
Thanks,
Ben
On 02/04/2019 03:11 AM, Koen Vandeputte wrote:
done & verified.
Thanks Ben!
Koen
On 03.02.19 04:27, Ben Greear wrote:
Here are the sha-sums, the 002 version changes to 003.
If someone could update openwrt to use them I'd appreciate it. Changelog
is at the bottom. I am hoping this resolves the crashes related to
rate-ctrl.
9980
6685623e2ee75909f734e45ae9321b9f78b18ed8c585eadef88f951b8aa4b3be
firmware-5-ct-full-community-12.bin-lede.003
ea5ccdc88a1371e958b4b5e7657782b1bcc55ac24e11e6fa36a3fce2746be4d6
firmware-5-ct-full-htt-mgt-community-12.bin-lede.003
/home/greearb/candela_html/downloads
9984
0815fffb4757596a5ee41efb8353fb90667e4c26363fbd62a5ccf269e9a55938
firmware-5-ct-full-community-12.bin-lede.003
425b66e51039f1970802940c864ad3d6b743926e310006f6601acb9689144315
firmware-5-ct-full-htt-mgt-community-12.bin-lede.003
/home/greearb/candela_html/downloads
4019
6e9171d012b50053b04572933b619927070b95fd2d8b9274a3e59a374088a09d
firmware-5-ct-full-community-12.bin-lede.003
b265428fadda7e3ac33ef977ba1a13788914689110275e57bba7796c583f8480
firmware-5-ct-full-htt-mgt-community-12.bin-lede.003
/home/greearb/candela_html/downloads
9888
fba3ce709cd0e17abec260639034bc99b0157f36c044713201cff2e5b408a6e2
firmware-5-ct-full-community-12.bin-lede.003
943c0ec1967a41f16e27fd1dfebefc9196412d48d4deba204b157bd7b9b90512
firmware-5-ct-full-htt-mgt-community-12.bin-lede.003
* Jan 2, 2019: Rebase patches to make 9980 bisectable.
* Jan 2, 2019: Fix scheduling related assert when wal-peer is deleted with
pending
tx buffers (bug 54, and others)
* Jan 7, 2019: Fix specifying retransmits for AMPDU frames. It was
previously ignored
since it is a 'software' retransmit instead of a hardware retransmit.
* Jan 9 2019: Fix potential way to get zero rates selected (and then assert)
* Jan 18 2019: pfsched has specific work-around to just return if we find
invalid flags AND
if we are in an out-of-order situation. Maybe this is last
of the pfsched
related issues (bug 54 and similar).
* Jan 24 2019: The rcSibUpdate method can be called concurrently with IRQ
tx-completion callback,
and that could potentially allow the tx-completion callback
to see invalid state
and assert or otherwise mess up the rate-ctrl logic. So,
disable IRQs in
rcSibUpdate to prevent this. Related to bug 58.
* Jan 28 2019: Ensure that cached config is applied to ratectrl objects
when fetched from
the cache. This should fix part of bug 58.
* Jan 28 2019: Ensure that ratectrl objects from cachemgr are always
initialized. This fixes
another part of bug 58.
* Jan 30 2019: Better use of temporary rate-ctrl object. Make sure it is
initialized, simplify
code path. This finishes up porting forward similar changes
I made for wave-1
firmware long ago, and fixes another potential way to hit
bug-58 issues.
* Jan 30 2019: Cachemgr did not have a callback for when memory was
logically freed. This means
that peers could keep stale references to rate-ctrl objects
that were in process
of being DMA'd into to load a different peer's rate-ctrl
state. This was causing
the bugcheck logic to fail early and often, and I suspect it
might be a root cause
of bug 58 as well. The fix is to add a callback and set any
'deleted' memory references
to NULL so that we cannot access it accidentally. Thanks to
excellent logs and patience
from the bug-58 reporter!
Thanks,
Ben
--
Ben Greear <gree...@candelatech.com>
Candela Technologies Inc http://www.candelatech.com
_______________________________________________
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel
