Hi! On Tue, Jan 22, 2019 at 3:16 AM R. Diez via openwrt-devel <openwrt-devel@lists.openwrt.org> wrote: ... > If Git fails with a "fatal" error inside getver.sh, how come the build does > not stop at that point?
Failed to calculate current revision isn't a "fatal error". As you can see in getver.sh it falls back to reporting an "unknown" version and the rest of the buildroot works just fine. A exact revision isn't a must during the entire building procedure. > For example: do we still need support for "version" and "hg" (Mercurial) in > that script? The version file is for people to easily set their custom version if they want. (e.g. if a manufacturer wants to pack their own OpenWrt buildroot for their customers, this feature is useful) As for hg OpenWrt never officially uses this as a version controlling tool. I think it's there so that it's convenient when people want to use this in their custom branch. It was added 10 years ago in svn r17432. > > Best regards, > rdiez > > _______________________________________________ > openwrt-devel mailing list > openwrt-devel@lists.openwrt.org > https://lists.openwrt.org/mailman/listinfo/openwrt-devel _______________________________________________ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
