On Mon, 7 Jan 2019 at 11:42, Petr Štetiar <yn...@true.cz> wrote: > > Daniel Golle <dan...@makrotopia.org> [2019-01-07 10:03:09]: > > Hi, > > > One. The MT7621 EVB. The TP-LINK RE350 v1 can probably be converted to > > a more sane flash partition layout to gain another megabyte or so. > > I've looked only at mt7621, so this was just example from one subtarget of > ramips target. So I tend to believe, that there's quite more such cases hidden > in the tree. Please correct me if I'm wrong. > > > Why specific devices? Wouldn't all devices with the resources (which > > boils down to !SMALL_FLASH) be potentially more useful with those > > kernel features enabled? > > You currently can't use !SMALL_FLASH, because this is target/subtarget > specific feature, not per device feature. I think, that in order to use this > feature, you would need to convert/fix all devices like that TP-Link RE350 > from all (sub)targets into tiny subtarget and then you could freely use > !SMALL_FLASH.
I agree with not abusing small_flash for that. It has a clear defined meaning, and shouldn't have unrelated side effects. I think a new opt-in symbol for those targets with hardware virtualization support and/or beefy enough cpus would make more sense. Those virtualization options (probably) don't come for free, they will have also a memory and performance impact even when not actively used. How much that is (and if this assumption is true) would be nice to have in the PR/patch for it. Regards Jonas _______________________________________________ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
