John Crispin <j...@phrozen.org> wrote: > > > On 03/08/18 18:18, Thibaut VARÈNE wrote: > > Avoid having /sbin/wifi silently ignore unknown keywords and execute > > "enable"; instead display the help message and exit with an error. > > > > Signed-off-by: Thibaut VARÈNE <ha...@slashdirt.org> > > --- > > package/base-files/files/sbin/wifi | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/package/base-files/files/sbin/wifi > > b/package/base-files/files/sbin/wifi > > index 83befc0d6f..09e483ec55 100755 > > --- a/package/base-files/files/sbin/wifi > > +++ b/package/base-files/files/sbin/wifi > > @@ -241,5 +241,5 @@ case "$1" in > > reload) wifi_reload "$2";; > > reload_legacy) wifi_reload_legacy "$2";; > > --help|help) usage;; > > - *) ubus call network reload; wifi_updown "enable" "$2";; > > + *) usage; exit 1;; > > esac > > NAK, this changes expected behaviour. i regularly call "wifi" > to resync my config with runstate. > John
respectfully, the behaviour of the "wifi" command is one of the most obtuse parts of openwrt's tooling. It does "something" with no command output, and responds ~instantly. This is expected behaviour for very few people. even "wifi asdfasdfa" returns ~instantly, with no warning that it is an unknown command. Does the command perhaps not take arguments? What would they be? Do we _reallly_ have to keep it's behaviour this way? What this patch _is_ missing, is a new command to replace the old "anything but the other commands". ie, the one that does "ubus call network reload; wifi_updown "enable" "$2"" Sincerely, Karl Palsson
signature.html
Description: OpenPGP Digital Signature
_______________________________________________ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
