Hi Jo, Re:
On 2018-08-01 04:34 PM, LEDE Commits wrote: > jow pushed a commit to openwrt/openwrt.git, branch master: > https://git.lede-project.org/33dbe2c55da1480559092185c4ef071995d9bc90 > > commit 33dbe2c55da1480559092185c4ef071995d9bc90 > Author: Jo-Philipp Wich <j...@mein.io> > AuthorDate: Wed Aug 1 22:31:34 2018 +0200 > > Revert "ar71xx: ag71xx: Add connect message: fixed phy" > > This reverts commit 0b9f4e880807e3cfd22d12b929202e1edcdc577c. > > This change reportedly breaks connectivity on some ar71xx devices, so > revert it for now. > > Ref: https://github.com/openwrt/openwrt/pull/1217#issuecomment-409708087 > Reported-by: Hannu Nyman <hannu.ny...@iki.fi> > Signed-off-by: Jo-Philipp Wich <j...@mein.io> > --- > .../ar71xx/files/drivers/net/ethernet/atheros/ag71xx/ag71xx_phy.c | 7 > ------- > 1 file changed, 7 deletions(-) > > diff --git > a/target/linux/ar71xx/files/drivers/net/ethernet/atheros/ag71xx/ag71xx_phy.c > b/target/linux/ar71xx/files/drivers/net/ethernet/atheros/ag71xx/ag71xx_phy.c > index 53507ab5a3..daa373be69 100644 > --- > a/target/linux/ar71xx/files/drivers/net/ethernet/atheros/ag71xx/ag71xx_phy.c > +++ > b/target/linux/ar71xx/files/drivers/net/ethernet/atheros/ag71xx/ag71xx_phy.c > @@ -111,13 +111,6 @@ static int ag71xx_phy_connect_fixed(struct ag71xx *ag) > ag->duplex = pdata->duplex; > ag->speed = pdata->speed; > > - if (!ret) { > - dev_info(dev, "connected to fixed PHY at %s [uid=%08x, > driver=%s]\n", > - phydev_name(ag->phy_dev), > - ag->phy_dev->phy_id, ag->phy_dev->drv->name); > - } else { > - pr_err("Failed to connect to fixed PHY\n"); > - } > return ret; > } > > If someone is running with AG71XX debugging enabled, connectivity is liable to be broken, not by *these* patches but by the console mii_read and mii_write messages that slow mii communication down. Is this reported to do nasty things *without* debugging? Regards, Daniel _______________________________________________ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
