On 30 July 2018 at 22:35, John Crispin <j...@phrozen.org> wrote: > > > On 30/07/18 22:33, Christian Lamparter wrote: >> >> This patch fixes the a compile issue that was triggered by >> apm821xx/sata when kmod-regmap was selected. >> >> The CONFIG_REGMAP is declared in drivers/base/regmap/Kconfig >> as type "bool" and not "tristate". Hence the symbol should >> never be set to module, as this confuses the #if CONFIG_REGMAP >> guards in include/linux/regmap.h: >> >> |.../drivers/regulator/core.c:4041: undefined reference to >> `dev_get_regmap' >> |.../drivers/regulator/core.c:4042: undefined reference to >> `dev_get_regmap' >> |.../drivers/regulator/core.c:4044: undefined reference to >> `dev_get_regmap' >> |.../drivers/regulator/helpers.o: In function >> `regulator_is_enabled_regmap': >> |.../drivers/regulator/helpers.c:36: undefined reference to `regmap_read' >> |... > > i started a test build 2 minutes ago to figure this one out :-) thanks !
This is actually the wrong fix and papers over an issue in one of our local patches. We intentionally allow regmap to be built as a module, see https://github.com/openwrt/openwrt/blob/master/target/linux/generic/hack-4.14/259-regmap_dynamic.patch So there are likely some additional EXPORT_SYMBOL_GPL()s required instead. Regards Jonas _______________________________________________ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
