Hi Mathias,
Thanks for the review.
On Tue, Jun 26, 2018 at 06:36:23PM +0200, Mathias Kresin wrote:
> > +"tplink,tl-wr741nd-v4"|\
> > +"tplink,tl-wr740nd-v4")
> > + ucidef_set_led_netdev "wan" "WAN" "tp-link:green:wan" "eth1"
> > + ucidef_set_led_switch "lan1" "LAN1" "tp-link:green:lan1" "switch0"
> > "0x04"
> > + ucidef_set_led_switch "lan2" "LAN2" "tp-link:green:lan2" "switch0"
> > "0x08"
> > + ucidef_set_led_switch "lan3" "LAN3" "tp-link:green:lan3" "switch0"
> > "0x10"
> > + ucidef_set_led_switch "lan4" "LAN4" "tp-link:green:lan4" "switch0"
> > "0x02"
> > + ucidef_set_led_wlan "wlan" "WLAN" "tp-link:green:wlan" "phy0tpt"
>
> Please use the linux,default-trigger devicetree property to set the
> phy0tpt trigger. Have a look at the existing ath79 dts files for
> examples.
>
I'll fix it in the v2.
> > + ;;
> > ;;
> >
> > + "tplink,tl-wr741nd-v4"|\
> > + "tplink,tl-wr740nd-v4")
> > + ucidef_set_interfaces_lan_wan "eth0.1" "eth1"
>
> ucidef_add_switch should already set the lan interface. A
> ucidef_set_interface_wan "eth1" should be sufficient here.
>
I'll fix it in the v2.
> > +
> > + memory@0 {
> > + device_type = "memory";
> > + reg = <0x0 0x2000000>;
> > + };
>
> The pending https://github.com/openwrt/openwrt/pull/1091 is about to
> remove all memory nodes in favour of the automatic memory detection.
> Would you please test if the correct of amount of memory is detected
> without the node. If so, the node can be removed.
>
I confirm that the correct amount of memory is detected without the memory node.
Best,
Rocco
_______________________________________________
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel
