Hi
ramips:MiWifi-Nano-change gpios to leds, add to default build group
space after the ":" space before and after the "-"
On 19/03/2016 20:49, Noble Pepper wrote:
> Signed-off-by: Noble Pepper <openwrtm...@noblepepper.com>
>
Description missing
> ---
> v2 changes - fix spelling, remove comments
>
> Note: Red led is not functional, appears to be issue in pinctrl system
> fix for this will follow at later date.
> ---
> ---
2 additional not needed tear lines
> target/linux/ramips/base-files/etc/board.d/01_leds | 7 ++++
> target/linux/ramips/dts/MIWIFI-NANO.dts | 40
> +++++++++-------------
> target/linux/ramips/image/Makefile | 1 +
> 3 files changed, 24 insertions(+), 24 deletions(-)
>
> diff --git a/target/linux/ramips/base-files/etc/board.d/01_leds
> b/target/linux/ramips/base-files/etc/board.d/01_leds
> index 6c25c86..4723a62 100755
> --- a/target/linux/ramips/base-files/etc/board.d/01_leds
> +++ b/target/linux/ramips/base-files/etc/board.d/01_leds
> @@ -185,6 +185,13 @@ miniembplug)
> miwifi-mini)
> ucidef_set_led_default "power" "power" "$board:red:status" "1"
> ;;
> +miwifi-nano)
> + ucidef_set_led_default "power" "power" "$board:red:status" "1"
> + ucidef_set_led_default "radio_led" "radio" "$board:amber:radio" "1"
> + ucidef_set_led_wlan "radio_led" "radio" "$board:amber:radio" "phy0radio"
> + ucidef_set_led_default "wifi_led" "wifi" "$board:blue:wifi" "1"
> + ucidef_set_led_wlan "wifi_led" "wifi" "$board:blue:wifi" "phy0assoc"
why do you add a default and a trigger type here ?
John
> + ;;
> mlw221|\
> mlwg2)
> set_wifi_led "$board:blue:wifi"
> diff --git a/target/linux/ramips/dts/MIWIFI-NANO.dts
> b/target/linux/ramips/dts/MIWIFI-NANO.dts
> index ea7b270..d46fc2d 100644
> --- a/target/linux/ramips/dts/MIWIFI-NANO.dts
> +++ b/target/linux/ramips/dts/MIWIFI-NANO.dts
> @@ -18,38 +18,30 @@
> pinctrl {
> state_default: pinctrl0 {
> gpio {
> - ralink,group = "gpio";
> + ralink,group = "refclk", "wled", "gpio";
> ralink,function = "gpio";
> };
> };
> };
>
> - gpio-export {
> - compatible = "gpio-export";
> - #size-cells = <0>;
> + gpio-leds {
> + compatible = "gpio-leds";
>
> - gpio11 {
> - /* blue led */
> - gpio-export,name = "gpio11";
> - gpio-export,direction_may_change = <1>;
> - gpio-export,output = <1>;
> - gpios = <&gpio0 11 0>;
> + wifi {
> + label = "miwifi-nano:blue:wifi";
> + gpios = <&gpio0 11 1>;
> + default-state = "1";
> };
> + status {
> + label = "miwifi-nano:red:status";
> + gpios = <&gpio1 5 1>;
> + default-state = "on";
> + };
> + radio {
> + label = "miwifi-nano:amber:radio";
> + gpios = <&gpio1 12 1>;
> + default-state = "1";
>
> - gpio37 {
> - /* red led */
> - gpio-export,name = "gpio37";
> - gpio-export,direction_may_change = <1>;
> - gpio-export,output = <1>;
> - gpios = <&gpio1 5 0>;
> - };
> -
> - gpio44 {
> - /* yellow led */
> - gpio-export,name = "gpio44";
> - gpio-export,direction_may_change = <1>;
> - gpio-export,output = <1>;
> - gpios = <&gpio1 12 0>;
> };
> };
>
> diff --git a/target/linux/ramips/image/Makefile
> b/target/linux/ramips/image/Makefile
> index 45cb22b..0cfb8fb 100644
> --- a/target/linux/ramips/image/Makefile
> +++ b/target/linux/ramips/image/Makefile
> @@ -1154,6 +1154,7 @@ Image/Build/Profile/WRTNODE2P=$(call
> BuildFirmware/Default16M/$(1),$(1),wrtnode2
>
> ifeq ($(SUBTARGET),mt7628)
> define Image/Build/Profile/Default
> + $(call Image/Build/Profile/MIWIFI-NANO,$(1))
> $(call Image/Build/Profile/MT7628,$(1))
> $(call Image/Build/Profile/WRTNODE2P,$(1))
> endef
>
_______________________________________________
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
