On 02/19/2016 at 6:32 AM, John Crispin wrote: > > > On 18/02/2016 14:13, Martin Schiller wrote: > > By setting the FID of a VLAN group to a value other then the default (0) it > > is possible to switch from Shared VLAN Learning to Independant VLAN > Learning. > > > > and what are the pro / cons of doing so ?
Independant: On incoming VLAN traffic the source MAC address is learned but is not made available for other VLANs (with other FIDs). Shared: The learned MAC address information is shared between multiple VLANs (with the same FID). This feature is used for example to separate the LAN and WAN interfaces. (like I described here: https://lists.openwrt.org/pipermail/openwrt-devel/2016-February/039758.html) [...] > > [...] > > > +static int xrx200sw_set_vlan_ports(struct switch_dev *dev, struct > switch_val *val) > > +{ > > +int i, portmap, tagmap, untagged; > > @@ -1022,6 +1051,14 @@ Subject: [PATCH 25/36] NET: MIPS: lantiq: adds > xrx200-net > > +}, > > +{ > > +.type = SWITCH_TYPE_INT, > > ++.name = "fid", > > ++.description = "Filtering Identifier (0-63)", > > ++.set = xrx200sw_set_vlan_fid, > > ++.get = xrx200sw_get_vlan_fid, > > ++.max = 63, > > ++ }, > > > i am not sure it is a good idea to export these options to user(land). > why do you need them ? I'm also not happy with this additional option, but for the use case above for example I don't think we can set the fid in an "automatic" way. > > > ++{ > > ++.type = SWITCH_TYPE_INT, > > +.name = "enable", > > +.description = "Enable VLAN", > > +.set = xrx200sw_set_vlan_enable, > > _______________________________________________ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel