-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 Michal schrieb am 31.01.2016 um 22:53: > On Sat, 30 Jan 2016 19:05:37 +0100 > Hartmut Knaack <knaac...@gmx.de> wrote: > >> -----BEGIN PGP SIGNED MESSAGE----- >> Hash: SHA256 >> >> Michal schrieb am 27.01.2016 um 01:33: >>> From: Michal Cieslakiewicz <michal.cieslakiew...@wp.pl> >>> >>> Enable platform-supplied WLAN LED name for ath9k device. >>> >>> Signed-off-by: Michal Cieslakiewicz <michal.cieslakiew...@wp.pl> >> Acked-by: Hartmut Knaack <knaac...@gmx.de> >>> --- >> >> Looking good overall. I also used this patch series to build >> images for the WPN824N to test button support, connected via >> the AR9285 GPIOs - no complains. >> One very minor detail about the patch subject: it would be >> good to prefix even with mac80211: ath9k: enable platform... >> It is also good practice to add a description and your >> Signed-off-by to the package patches. Many people don't seem >> to have done this, as well, but it makes life easier for the >> one who will eventually send these patches upstream. >> > > Hello Hartmut, > > Formal question: does "description and signing package patches" means > including filled cover letter (from git-format-patch) as sort of > preamble to all 8 patches or should I modify heading comments in > patched files themselves ? >
Hi Michal, I would say, just add a Subject line, a short description and most important your Signed-off-by line to the patches created with quilt. See for example some of the patches in target/linux/ar71xx/patches-4.1. The 8 patches, created with git, are fine. Thanks, Hartmut > Regards > Michal > -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJWrpNiAAoJEANoShj6yJFIckEP/1zJN1E3xL8og+fOAP6oQaC+ /XuXYutyC+SKQy55onEFZKX1TY0CNZWS+3+kRwkcMIZpxW602MM02X4iRYJ+mq3x fn0L+zOgVudJeJYuIQtDH5QGyk5jRZGTyoeyNriwH+1tdPhxGkI7SbImQPBHYGI7 htYev4qqTnnJ4LEnUjfywKdanKOLEAijbivmpQqp7dsUu3HaviftqU6EcDhQt8fr pDOnDBZgmIwd7avVpXeYf5r6f7tTFpF+YyBceig68EYGYdzBVLPfsbMIomHZnApZ B7SbqdvjP2wt+NRNyc1KgdFNG1j/9pmhuythxNYb7wv2nRqvDsrs2kS1S/j0U8/0 nJWGGzDUimPCUzzgea+Q+4+kieTE57USVMQHcf+VKsp91AF/EuWeBNv8TJ0Iz+o/ +MsUaF5qarfVwu5E+PXUy8dliAzFu2b3uIYaLIDiserIbVs5pW8nPIBXV/Gyidx5 2tLhRvpt4YonhVVKDNFYQeR4USRujX+eqeH5JjnNEIzXS3GUuC7Qy2/zxVxUwn9x 2w8moysbouyeeFIHnF7eLBtnIF4iftnWMFcFV69ehnxNTS6htXiEapuNrwxUxinv gTySCbUgs+QNfOZedIHQszE2PWKnBKvtAsKifHsi8Jg7wDB+lgswHgh9ivrijFSh f/cj3y24ysou3GlHtRfz =NA0k -----END PGP SIGNATURE-----
0xFAC89148.asc
Description: application/pgp-keys
_______________________________________________ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
