On 12/31/2015 02:51 PM, John Crispin wrote: > > > On 31/12/2015 14:44, Hauke Mehrtens wrote: >> >> >> On 12/31/2015 11:28 AM, John Crispin wrote: >>> >>> >>> On 31/12/2015 10:51, Mathias Kresin wrote: >>>> Am 31.12.2015 um 08:12 schrieb John Crispin: >>>>> Hi >>>>> >>>>> On 31/12/2015 01:10, Martin Blumenstingl wrote: >>>>>> + >>>>>> +#if LINUX_VERSION_CODE >= KERNEL_VERSION(4,2,0) >>>>>> +#include <linux/scatterlist.h> >>>>>> +#else >>>>>> #include <asm/scatterlist.h> >>>>>> +#endif >>>>> >>>>> please just drop the old code. there is no need to be compatible to old >>>>> kernels. >>>>> >>>>> John >>>>> >>>> >>>> I guess we should keep the compatibility with Kernel 4.1 as long as this >>>> kernel version is the default for this target and/or available for this >>>> target. >>> >>> i was planning to jump straight to 4.4 >>> >>> John >> >> Linux 4.1 already has include/linux/scatterlist.h, I assume that this >> will also compile with linux 4.1 when you use #include <linux/scatterlist.h> >> >> Hauke >> > > anyone wanna try ? :) i am short on time the next 2-3 days and need to > fight the backlog before i can start on new tasks. > > John
Kernel 4.1 still builds without the ifdef and only using the linux/scatterlist.h include. Hauke _______________________________________________ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
