Hi, On 11/12/2015 10:32:08 CET, John Crispin wrote:
1) the subject and description dont match.
Well, the description is an addition to the subject, but okay.
2) why would we want to intermingle the portmap and register init variables. they are 2 different things. imho that is not correct
Because there are two __be32's used to fetch data from the device tree; one is used only once for the portmap, while the other is used three times, for the two registers and for the led_polarity. Maybe the name should be tmp instead, but I think that the variable should be just one here. Cheers, Vittorio G _______________________________________________ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
