On Sun, Jul 26, 2015 at 9:34 PM, Piotr Dymacz <pep...@gmail.com> wrote: > 2015-07-26 21:16 GMT+02:00 Imre Kaloz <ka...@openwrt.org>: >> >> On Sun, 26 Jul 2015 18:24:30 +0200, Piotr Dymacz <pep...@gmail.com> wrote: >> >>> For some boards in ramips (and other targets) naming scheme for LEDs is: >>> "manufacturer:color:led-name", but there are many other boards which don't >>> follow this approach. >> >> >> The upstream convention is "device:color:led-name". So actually, the wrong >> way is where we do the other way around. > > That's bad news... I will fix it. > But, why then patches with wrong convention are still accepted? > > Examples: > https://dev.openwrt.org/changeset/46248 > https://dev.openwrt.org/changeset/46349 > https://dev.openwrt.org/changeset/46444 > https://dev.openwrt.org/changeset/46454 > https://dev.openwrt.org/changeset/46458
Sometimes things slip through. People do mistakes. > And, when the convention was changed? It has always been this way since 2006: https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=75c1d31d9ea71025b73430c696b727e8aa15872d only the ":function" part was added a year later. Jonas _______________________________________________ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
