On 06/22/2015 02:51 AM, Ian Kent wrote: > On Sun, 2015-06-21 at 19:19 +0200, Rafał Miłecki wrote: >> On 10 March 2015 at 04:30, Ian Kent <ra...@themaw.net> wrote: >>> The Netgear R8000 has a PEX8603 connected to the BCM53012 and if >>> it isn't configured during the bus scan the PCI layer goes crazy >>> trying to configure phantom devices. >> >> This is kind of magic for me. >> Hauke: are you able to review this? > > Yeah, it's a bridge so it needs upstream and downstream bus ids set but > the main issue is that it doesn't respond with appropriate return values > for non-existent devices. > > I modelled the code on the corresponding source from the Broadcom SDK > file that this source was originally developed from (at least it > appeared to match). > > I confirmed that PEX860X devices don't return proper return code from > another PEX driver, from the WRT1900 source I think, its been a while > now. > > Ian
Hi, I completely missed these patches, thanks for pointing me to them again. I will try to review them in the net days. I already saw this code in the vendor driver but did not add it because my devices did not use it. We will change to a different PCIe driver with the next kernel in OpenWrt, because Broadcom added a kernel for this PCIe core into the mainline kernel. We should get it into this new driver. Then also some people from Broadcom can review this. Hauke _______________________________________________ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel