On 06/10/2015 04:27 PM, Hendrik Lüth wrote: > Am 10.06.2015 um 14:31 schrieb Bastian Bittorf: >> * Matthias Schiffer <mschif...@universe-factory.net> [10.06.2015 14:26]: >>> Why should errors in these files cause login issues? This is shell and >>> there's no -e, problematic lines will print an error and be skipped. >> i have seen a lot of strange things. think about >> flash readerrors or stack corruption or $youridea 8-) >> >> i think we can agree that we will not use a subshell, >> but ignore profile.d in failsafe mode, ok? the 'sh -n' >> thing is just a small 'insurance' - do you think it hurts/is too much? >> >> bye, bastian > > I'd like to see, that the scripts in profile.d are getting called > without the 'sh' because those scripts could be written in Lua, too. > Weather a script needs to get called in failsafe mode or not depends on > the script, so I'd like to not skip it. > > regards, Hendrik
That's not at all what profile.d is about. profile.d is for shell snippets that are *sourced* into the login shell, not executed, so they must be shell code. If you want to call Lua scripts, just call Lua from the shell code. I agree that it would make sense to skip profile.d in failsafe mode.
signature.asc
Description: OpenPGP digital signature
_______________________________________________ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
