Current behaviour on system upgrade is to disabled the 'upnpd' service on first boot. This was originally implemented in 2008 (https://github.com/openwrt/luci/commit/66fa0eb0e8e206d26e16615941c60b22b5004649) as a security feature.
The 'auto disable' function only occurs on first boot after an upgrade and only
if the luci-upnp package is installed.
In all other cases auto disabling of 'upnpd/miniupnpd' service does not occur.
This is inconsistent & confusing, not
only in user interface/state handling but also in security.
Either
a) disable the service at first boot after upgrade in all cases
b) Treat upnp like any other service on the router, leaving it in its
configured state across upgrades, whether luci-upnp
package is installed or not.
c) Consider disabling all optional services across upgrade (transmission,
samba, asterisk, etc...)
The patch takes option b) and stops luci-upnp from disabling the service on
first boot after an upgrade.
Signed-off-by: Kevin Darbyshire-Bryant <ke...@darbyshire-bryant.me.uk>
diff --git a/applications/luci-app-upnp/root/etc/uci-defaults/luci-upnp
b/applications/luci-app-upnp/root/etc/uci-defaults/luci-upnp
deleted file mode 100755
index fe22a3e..0000000
--- a/applications/luci-app-upnp/root/etc/uci-defaults/luci-upnp
+++ /dev/null
@@ -1,9 +0,0 @@
-#!/bin/sh
-
-/etc/init.d/miniupnpd enabled && {
- /etc/init.d/miniupnpd stop
- /etc/init.d/miniupnpd disable
-}
-
-rm -f /tmp/luci-indexcache
-exit 0
smime.p7s
Description: S/MIME Cryptographic Signature
_______________________________________________ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
