Two errors "netifd: radio0: sh: bad number" have recently surfaced in system log in trunk when wifi interfaces come up. I tracked the errors to checking numerical values of some config options without ensuring that the option has any value.

The errors I see have apparently been introduced by r45051 (ieee80211r in hostapd) and r45326 (start_disabled in mac80211). My patches fix two instances of "bad number", but there may be a third one, as the original report in bug 19345 pre-dates r45326 and already has two "bad number" errors for radio0.

https://dev.openwrt.org/ticket/19345

Signed-off-by: Hannu Nyman <hannu.ny...@iki.fi>

Index: package/network/services/hostapd/files/netifd.sh
===================================================================
--- package/network/services/hostapd/files/netifd.sh    (revision 45369)
+++ package/network/services/hostapd/files/netifd.sh    (working copy)
@@ -346,6 +350,7 @@
 
        if [ "$wpa" -ge "1" ]; then
                json_get_vars nasid ieee80211r
+               set_default ieee80211r 0
                [ -n "$nasid" ] && append bss_conf "nas_identifier=$nasid" "$N"
 
                if [ "$ieee80211r" -gt "0" ]; then
_______________________________________________
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel

Reply via email to