This restores normal pre-r43715 200ms blink-period for the System LED we're all
accustomed to see while our OpenWrt routers are booting.
Failsafe possibility will now be signalled with a new 100ms blinking, which is
easily recognizable from the normal 200ms booting.
So no existing user will be scared by a new 500ms LED pattern, since such a
slow pattern could easily be mistaken for something wrong... I was like "ok why
my router is collapsing now, is this a bad flash, a kernel panic, or what else"
when I've seen it for the first time ;)
Sorry for not having explained myself better in v1 of this patch.
Original:
Preinit, failsafe is possible: 200ms
Preinit, failsafe not possible anymore, booting normally: 200ms
Failsafe entered: 50ms
Now (after preinit_regular has been introduced):
Preinit, failsafe is possible: 200ms
Preinit, failsafe not possible anymore, booting normally: 500ms *here is the
"offending" change*
Failsafe entered: 50ms
With my proposed patch:
Preinit, failsafe is possible: 100ms *indicate this condition with a new
timing, that prompts the user to press the key if they want to start failsafe*
Preinit, failsafe not possible anymore, booting normally: 200ms *keep this as
before*
Failsafe entered: 50ms
Signed-off-by: Vittorio Gambaletta <open...@vittgam.net>
diff --git a/package/base-files/files/lib/functions/leds.sh
b/package/base-files/files/lib/functions/leds.sh
index 4ac8145..d4d4512 100644
--- a/package/base-files/files/lib/functions/leds.sh
+++ b/package/base-files/files/lib/functions/leds.sh
@@ -60,7 +60,7 @@ status_led_blink_fast() {
}
status_led_blink_preinit() {
- led_timer $status_led 200 200
+ led_timer $status_led 100 100
}
status_led_blink_failsafe() {
@@ -68,5 +68,5 @@ status_led_blink_failsafe() {
}
status_led_blink_preinit_regular() {
- led_timer $status_led 500 500
+ led_timer $status_led 200 200
}
_______________________________________________
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
