AR8327/AR8337 are quite different from the rest of the AR8216 switch chip family and share only a certain amount of code with the rest of the family. Therefore I think it makes sense to factor out the AR8327/AR8337 driver code into separate header / source file.
As a side effect this would allow to relatively easy create the option to compile a smaller AR8216/AR8236/AR8316 driver w/o the AR8327/AR8337 code. And it improves maintainability IMHO. Heiner Kallweit (2): ar8216: move definitions from ar8216.c to ar8216.h and introduce ar8327.h ar8216: factor out AR8327/AR8337-specific driver code into ar8327.c .../linux/generic/files/drivers/net/phy/ar8216.c | 1467 ++------------------ .../linux/generic/files/drivers/net/phy/ar8216.h | 384 ++--- .../linux/generic/files/drivers/net/phy/ar8327.c | 1029 ++++++++++++++ .../linux/generic/files/drivers/net/phy/ar8327.h | 224 +++ .../generic/patches-3.10/724-phy_ar8216.patch | 2 +- .../generic/patches-3.10/725-phy_rtl8306.patch | 2 +- .../generic/patches-3.10/726-phy_rtl8366.patch | 2 +- .../generic/patches-3.13/724-phy_ar8216.patch | 2 +- .../generic/patches-3.13/725-phy_rtl8306.patch | 2 +- .../generic/patches-3.13/726-phy_rtl8366.patch | 2 +- .../generic/patches-3.14/724-phy_ar8216.patch | 2 +- .../generic/patches-3.14/725-phy_rtl8306.patch | 2 +- .../generic/patches-3.14/726-phy_rtl8366.patch | 2 +- .../generic/patches-3.14/733-phy_mvsw6171.patch | 2 +- .../generic/patches-3.18/724-phy_ar8216.patch | 2 +- .../generic/patches-3.18/725-phy_rtl8306.patch | 2 +- .../generic/patches-3.18/726-phy_rtl8366.patch | 2 +- .../generic/patches-3.18/733-phy_mvsw6171.patch | 2 +- .../linux/generic/patches-3.3/724-phy_ar8216.patch | 2 +- .../generic/patches-3.3/725-phy_rtl8306.patch | 2 +- .../generic/patches-3.3/726-phy_rtl8366.patch | 2 +- .../linux/generic/patches-3.8/724-phy_ar8216.patch | 2 +- .../generic/patches-3.8/725-phy_rtl8306.patch | 2 +- .../generic/patches-3.8/726-phy_rtl8366.patch | 2 +- 24 files changed, 1634 insertions(+), 1510 deletions(-) create mode 100644 target/linux/generic/files/drivers/net/phy/ar8327.c create mode 100644 target/linux/generic/files/drivers/net/phy/ar8327.h -- 2.1.3 _______________________________________________ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
