Hi!

I just noted that there is an issue with the firmware upgrade via LuCI
on the OM2P. The image validity check fails, because the following
script in system.lua fails:

        local function image_supported()
                -- XXX: yay...
                return ( 0 == os.execute(
                        ". /lib/functions.sh; " ..
                        "include /lib/upgrade; " ..
                        "platform_check_image %q >/dev/null"
                                % image_tmp
                ) )
        end

Calling "platform_check_image" directly fails due to the way
target/linux/ar71xx/base-files/lib/upgrade/openmesh.sh is written
("break"), but I believe the better way would be to use "sysupgrade -T"
anyhow - it works if I change the code like this:

        local function image_supported()
                return ( 0 == os.execute(
                        "sysupgrade -T %q >/dev/null"
                                % image_tmp
                ) )
        end

Any chance to get this into LuCI or should /lib/upgrade/openmesh.sh be
rewritten to be compatible with the ("yay") LuCI way?

bruno
_______________________________________________
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel

Reply via email to