Sorry, accidentally droped the Mailinglist in my last message. Those coming late to the party: See the fullquote below...
On Fri, 26 Sep 2014 23:58:03 +0200, Hartmut Knaack <knaac...@gmx.de> wrote: > har...@ccbib.org schrieb am 26.09.2014 22:33: >> Hi! >> >> On Fri, 26 Sep 2014 21:03:07 +0200, Hartmut Knaack <knaac...@gmx.de> >> wrote: >>> har...@ccbib.org schrieb am 26.09.2014 12:46: >>>> The DHT11 is a temperature and humidity sensor supported by linux >>>> since 3.14. >>>> >>>> This patch has been tested on recent mxs with kernel 3.14.18. >>>> >>>> Signed-off-by: Harald Geyer <har...@ccbib.org> >>> Hi, >>> I would expect to make it also depend on device tree or architectures >>> which support device tree. From what I remember, there are still >>> architectures which have not yet been converted to devicetree. In those >>> cases, it would be confusing and useless to build this module. Or am I >>> missing something? I don't have any practical experience with >> devicetree, >>> so far. >> >> I did raise this point when submitting the driver for review and the >> answer >> was: Don't bother. Anyway, the driver explicitely does not depend >> on devicetree in the Kconfig file to allow for compile testing on those >> non-devicetree architectures. - OTOH maybe OpenWrt cares more about end >> user experience than kernel hackers do? > That's weird, as there are some cases in IIO, where || COMPILE_TEST is > added as dependency (at least I have seen this for platform specific > devices). Yes, but it seems || COMPILE_TEST is considered a hack that is to be avoided. The devicetree API is a noop on non-devicetree architectures to get rid of || COMPILE_TEST. > Anyway, while compiling the kernel still requires some advanced skills, > OpenWRT should be heavily dedicated at end-users - so you need to make it > kind of idiot-proof. And not everyone able to solder will have the kernel > experience, as well. So, sooner or later I would expect people to come up > to the forum asking, how to deal with a custom device tree file, and > someone has to explain that it won't work with their router, which raises > the question, why the kernel module is built, if the router doesn't support > it. So, in my opinion, it would be best to make it depend on CONFIG_OF to > avoid any confusion. Okay, I'll test and submit an updated patch. best regards, Harald >> If somebody want's to use this driver on an architecture without >> devicetree, >> I'm sure support for this will be added. OTOH depending on archtectures >> which support devicetree would be a moving target and rather impractical. >> >> It sure will be useless to build this module on some architectures, but I >> don't think it will be confusing: If somebody want's to attach the driver >> to a gpio line they will obviously notice what they are missing. >> >> So in conclusion I'd like to keep this as is but am willing to reconsider >> if there is prior practise regarding devicetree to the contrary in >> OpenWrt. >> >> best regards, >> Harald >> >>>> --- >>>> package/kernel/linux/modules/other.mk | 20 ++++++++++++++++++++ >>>> 1 files changed, 20 insertions(+), 0 deletions(-) >>>> >>>> diff --git a/package/kernel/linux/modules/other.mk >>>> b/package/kernel/linux/modules/other.mk >>>> index d56bb50..bef24eb 100644 >>>> --- a/package/kernel/linux/modules/other.mk >>>> +++ b/package/kernel/linux/modules/other.mk >>>> @@ -258,6 +258,26 @@ endef >>>> >>>> $(eval $(call KernelPackage,iio-ad799x)) >>>> >>>> + >>>> +define KernelPackage/iio-dht11 >>>> + SUBMENU:=$(OTHER_MENU) >>>> + DEPENDS:=kmod-iio-core @GPIO_SUPPORT >>>> + TITLE:=DHT11 (and compatible) humidity and temperature sensors >>>> + KCONFIG:= \ >>>> + CONFIG_DHT11 >>>> + FILES:=$(LINUX_DIR)/drivers/iio/humidity/dht11.ko >>>> + AUTOLOAD:=$(call AutoLoad,56,dht11) >>>> +endef >>>> + >>>> +define KernelPackage/iio-dht11/description >>>> + support for DHT11 and DHT22 digitial humidity and temperature sensors >>>> + attached at GPIO lines. You will need a custom device tree file to >>>> + specify the GPIO line to use. >>>> +endef >>>> + >>>> +$(eval $(call KernelPackage,iio-dht11)) >>>> + >>>> + >>>> define KernelPackage/lp >>>> SUBMENU:=$(OTHER_MENU) >>>> TITLE:=Parallel port and line printer support >>>> >> _______________________________________________ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
