-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hi,
I had a look at other targets supposedly using ubinize: kirkwood doesn't define a single $(PROFILE)_UBI_OPTS variable, so no ubinized images are currently being built anyway. I reckon it makes sense to add similar settings than the ones I'm using on oxnas target, I could add these. imx6 got a custom hack to build several images for the same board profile and could benefit from using ubinize-image.sh. However, I guess it'd be easier for you to fix that yourself before merging 8/9 lantiq is easy to migrate and would benefit from having per-board-per-rootfs ubinized images. I could get some hardware (homehub2b) for testing, but probably you or John got lantiq test hardware at hand...? at91, xburst and omap apparently only generate the default ubinized images (?) containing only root.ubifs, that could also be easily migrated by defining Image/Build/ubifs to call ubinize-image.sh. I reckon we just postpone 8/9 for now. 9/9 doesn't depend on it and all other patches in the series shouldn't break anything... Cheers Daniel On 05/17/2014 11:55 PM, Luka Perkov wrote: > Hi Daniel, > > On Sat, May 17, 2014 at 09:37:17PM +0200, Daniel wrote: >> Yes, 9/9 needs all other targets to migrate to the script introduced by >> 7/9 for ubinized images to be generated. > > Migration of all other targets needs to happen before 8/9 so we don't break > the targets in any commit along the way. > > Luka > >> On May 17, 2014 9:03 PM, Luka Perkov <l...@openwrt.org> wrote: >>> >>> Hi Daniel, >>> >>> On Sat, May 17, 2014 at 07:30:46PM +0200, Daniel Golle wrote: >>>> See also >>>> https://gitorious.org/openwrt-oxnas/openwrt-oxnas/source/target/linux/ >>>> oxnas/image/Makefile >>> >>> Well, you haven't really answered my question. You are using this in >>> your Makefile: >>> >>> sh $(TOPDIR)/scripts/combined-image.sh \ ... >>> >>> So after 7/9 and before 8/9 we need to patch Makefiles for kirkwood, >>> imx6 and others to use this script, correct? >>> >>> Luka -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBAgAGBQJTd+olAAoJECBgbL4bcbCQAh4H/i5mrPyRZxQ1fkPDe/NO3rvu 7s/hxRbmvGA4Bmq/L2fKZHc4ihOvXYB7qsBKUfRQI5+S/VA0hsIbqlvhdlIbaQdx 6c6mowNvKvwaUqqmz/uzmowIlFX0gS+qSKGOEfYspo/v0dqHHw76lU+eGrqGIt58 0da+jwGRXkv7Yv3LaKpSYquIWEf3kMTm+lFHbJiaSbzjEvMwrul3DF9LQODn7a8J rn1GuINSlPBsFpF+MFocGDQGObSMvG1lH8euTPi+QD+bGYqIiuqVKo3GRegZryQZ h4tFFhwm73MqvgHkAbuzdL8v+BNCJnUgHvPpjjdpCc8k6Jz/wnUQFjsXptgKj4E= =W6HP -----END PGP SIGNATURE----- _______________________________________________ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
