On 05/10/2014 07:57 PM, Daniel Golle wrote:
Hi!
On 05/10/2014 06:45 PM, Marek Lindner wrote:
On Saturday 10 May 2014 16:38:42 Karl P wrote:
On 05/10/2014 10:53 AM, Marek Lindner wrote:
On Friday 09 May 2014 14:11:32 Karl Palsson wrote:
I understand how it works in general, John was nacking the support as it
duplicated existing functionality. I was asking more about this existing
functionality within openwrt for supporting dual firmware images. I
wasn't
aware of any existing functionality for this.
Check target/linux/ar71xx/base-files/lib/upgrade/openmesh.sh. All OpenMesh
boards provide exactly this kind of upgrade behavior.
Which of course begs the question why it's buried in openmesh support code
:)
Feel free to 'liberate' the code any way you see fit. I would not know how to
abstract this code in a meaningful way, so it could be re-used elsewhere but I
am certainly willing to review your patches on that matter.
I also implemented this for the ALL0258N in r28700, later added the necessary
abstraction to at least support all the similar Allnet devices within the same
script. When I saw the OM2P support was merged, I wasn't that happy to see a 90%
copy of an already ugly vendor-specific hack occupying flash-space on *all*
ar71xx-based devices... (ugly because the uImage header already got a checksum,
and if already start hacking on the bootloader, they could have implemented FIT
or alike)
Anyway, we are far from having decent U-Boot source coverage on ar71xx to
replace the affected bootloaders, so we'll have to deal with it. It should be
possible to further generalize the two existing scripts into one.
I'd be happy to provide assistance and code review in that matter. However, I do
not have time to work on this, nor casual access to testing devices which might
end up bricked and need recovery via serial...
So,
John Crispin, for the nack on the original patch, which of these two
alternatives are the "existing functionality" that is meant to be used, and how?
Cheers,
Karl P
_______________________________________________
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
