You can actually do that already with KERNEL_GIT_CLONE_URI alone.
GIT_LOCAL_REPOSITORY is used if you want the cloned tree to have the real 
remote tree as a remote (in this case, KERNEL_GIT_CLONE_URI is your remote, and 
GIT_LOCAL_REPOSITORY is your local clone); if you use KERNEL_GIT_CLONE_URI 
only, the remote will be your local tree.
I'm also not using this option much; clone is much faster to just point to the 
local git directly. A different remote can be added afterwards manually.
Should I post an updated patch to remove that option?

-----Original Message-----
From: Rafał Miłecki [mailto:zaj...@gmail.com] 
Sent: Friday, April 25, 2014 2:20 AM
To: Olivari, Mathieu
Cc: OpenWrt Development List
Subject: Re: [OpenWrt-Devel] [PATCH 1/4] config: make GIT_LOCAL_REPOSITORY 
depend on KERNEL_GIT_CLONE_URI

2014-04-25 5:43 GMT+02:00 Mathieu Olivari <math...@qca.qualcomm.com>:
> The GIT_LOCAL_REPOSITORY is pretty useless if KERNEL_GIT_CLONE_URI is 
> not set. The code in "include/" will actually be executed only if it's 
> set. So let's make it official and mark it as a dependency in the 
> configuration menu to avoid confusing the user.

This is a bit weird. I expected to be able to clone any repo on my own and tell 
OpenWrt to use. In such case OpenWrt shouldn't care about git repo URL, right? 
So I expect to simply set GIT_LOCAL_REPOSITORY and ignore KERNEL_GIT_CLONE_URI.

Maybe it's OpenWrt behavior that should be fixed?
_______________________________________________
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel

Reply via email to