Hello Rafal
I m aware with the source quality issue
And as answer to Luka concerning the "NEW PATCH version", we have sent a
new patches " [PATCH v2 00/10]" containing 10 patches that take account
the Luka remarks but he rejected them (the patches are not merged in the
freecwmp project).
Regards
Le 08/04/2014 17:23, Rafał Miłecki a écrit :
2014-04-08 16:43 GMT+02:00 KALLEL Mohamed <mohamed.kal...@pivasoftware.com>:
At the beginning, we tried to contribute to the freecwmp project
(http://www.linux-mips.org/archives/freecwmp/2012-12/threads.html#00076) but
we found that the contribution process takes time and we found that our way
and methods does not correspond to the freecwmp ways and methods.
Well, in open source world we often care a lot about quality. It's
needed to keep code in a nice shape and allow any developer at any
time to join the project.
I've quickly checked your commits sent back in 2012 and there were
many things correctly pointed out by Luka that you ignored. What you
sent as "NEW PATCH version":
1) Was incorrectly formatted (no [PATCH] tag, not version number,
sequence put at the end, no in-reply-to header)
2) Didn't address most of the comments from Luka
3) Was breaking code formatting
So there were good reasons your patches weren't accepted :(
So we
really appreciate if you add our EasyCwmp project to the OpenWRT packages.
Adding EasyCwmp package to the OpenWRT will enrich the OpenWRT package
database. And then it's up to the user to choose the package he wants (what
ever easycwmp or freecwmp or others) in the compilation phase (like the
microxml package and the minixml package)
I don't want to end up with two same-base projects developed
independently while they both could share improvements. Let's try to
play it wisely.
I will send you the changes (patches) to be applied to your freecwmp project
in order to be aligned with the EasyCwmp project.
The changes contains 65 patches and they include 45 files changed, 6588
insertions(+), 2280 deletions(-).
Your freecwmp code contains 6477 lines so the changes are major: 101%
insertions(+), 35% deletions(-).
Changes include a lot of white space changes, indention changes, etc.
A lot of code is still the same between the both projects.
Please share your repo / patches to the public *first*. I like your
list of changes, but we still need a bunch of patches you've developed
to work on this in a sane way.
_______________________________________________
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
