On Tue, Mar 4, 2014 at 1:02 AM, Hannu Nyman <hannu.ny...@iki.fi> wrote: > Quoting Tim Harvey <thar...@gateworks.com>: <snip> > > I have one comment to your patch: > I think that the last item on the line should be: > +PACKAGE_collectd-mod-nut:nut > so that the nut package gets conditionally selected, if collectd-mod-nut has > been selected. > > That would match the other similar collectd-mods. > > -$(eval $(call BuildPlugin,nut,UPS monitoring input,nut,nut)) > +$(eval $(call BuildPlugin,nut,UPS monitoring > input,nut,+PACKAGE_collectd-mod-nut:nut)) >
Hannu, Makes sense - I've posted an updated patch. Thanks, Tim _______________________________________________ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
