Hi ----- Mail original ----- > De: "Russell Senior" <russ...@personaltelco.net> > À: "OpenWrt Development List" <openwrt-devel@lists.openwrt.org> > Envoyé: Mardi 18 Février 2014 18:27:23 > Objet: [OpenWrt-Devel] [RFC] menuconfig policy? > > > I am working with the batman-adv people to split the feeds/routing > batman-adv package into separate kmod and user-space parts. There is > a user-space utility (not strictly required) called batctl that is > currently included in the batman-adv Makefile. The current Makefile > provides an option to also build batctl (defaults on, but can be > disabled), and then includes (or not) the batctl binary in the > batman-adv package. Batctl source is distributed in a separate > tarball, and the Makefile does various contortions to build them in > separate subdirectories of the $PKG_BUILD_DIR. > > In splitting the two parts into separate packages, a problem arises > insofar as how to "default on" the batctl package when selecting > kmod-batman-adv? What I suggested is to modify the existing > Config.in > to point at PACKAGE_batctl instead of KMOD_BATMAN_ADV_BATCTL (see > patch fragment befow). This results in an option for an associated > userspace tool, batctl, appearing in the Kernel section of the > Makefile, in addition to the Network section. Selection/deselection > appears to be coherent between the two sections (shows the same state > in both places). > > diff --git a/batman-adv/Config.in b/batman-adv/Config.in > index 1330525..aeefd35 100644 > --- a/batman-adv/Config.in > +++ b/batman-adv/Config.in > @@ -19,11 +19,12 @@ config KMOD_BATMAN_ADV_NC > depends on PACKAGE_kmod-batman-adv > default n > > -config KMOD_BATMAN_ADV_BATCTL > - bool "enable batctl" > +config PACKAGE_batctl > + tristate "enable batctl" > depends on PACKAGE_kmod-batman-adv > default y > help > batctl is a more intuitive managment utility for > B.A.T.M.A.N.-Advanced. > It is an easier method for configuring batman-adv and > provides some additional tools for debugging as well. > + > > The question becomes: Is this acceptable for OpenWrt? If not, is > there a better way? > > I understand there is a convention that the userspace parts depend on > the kernel parts, so that the kernel parts are auto-selected upon > selecting the user-space parts, e.g. in iptables and ppp. And, we > are > happy to do that here. However, in the batman-adv case, people who > want it are going to go looking in the Kernel section and not in the > Network section and might not even think to look for batctl unless it > is grouped together as it is now. Thoughts? >
Why not simply put a comment about batctl in kmod-batman-adv ? > Thanks! > > > -- > Russell Senior, President > russ...@personaltelco.net > _______________________________________________ > openwrt-devel mailing list > openwrt-devel@lists.openwrt.org > https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel > _______________________________________________ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel