On Thu, Feb 13, 2014 at 5:00 PM, Helmut Schaa
<helmut.sc...@googlemail.com> wrote:
> When setting the associated interface down and up again a new
> switch device will be registered due to b53_phy_config_init
> doing the necessary allocations and registrations.
>
> Instead, register the switch device already in b53_phy_probe.
>
> Signed-off-by: Helmut Schaa <helmut.sc...@googlemail.com>
> ---

It would be good to have some changelog here to know what changed
between v1, v2 and v3. As far as I can tell you are now dropping the
ethX alias completely? This will cause a lot of config breakage
because bcm47xx and bcm63xx use ethX as the default switch name for
most switch configs. We need to add a migration script first before
this can be applied (it would be good to have one anyway for the
kmod-switch -> swconfig migration.

The first two look good, and I will commit them as soon as I have
time, so no need to resend them.


Regards
Jonas
_______________________________________________
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel

Reply via email to