On Sun, Jan 19, 2014 at 3:01 PM, Oskari Rauta <oskari.ra...@gmail.com> wrote: >>Hi, >> >>NAK, we wont merge a huge pile of random patch churn in one big blob. >>please read the "submitting patches" guidelines >> >> John > > What huge pile? Like I earlierly said, this is NOT dependant of _any_ of my > previous patches and this is 5K patch patching the following 4 files: > target/linux/brcm2708/Makefile b/target/linux/brcm2708/Makefile > target/linux/brcm2708/patches-3.12/001-change-version.patch > b/target/linux/brcm2708/patches-3.12/001-change-version.patch > target/linux/generic/config-3.12 b/target/linux/generic/config-3.12 > > target/linux/generic/patches-3.12/880-gateworks_system_controller.patch > b/target/linux/generic/patches-3.12/880-gateworks_system_controller.patch > > If patch is unreadable because my mail program has sent it with incompatible > way, you can fetch the patch from: > https://sites.google.com/site/variousopenwrt/rpi-patch > > Yeah, I have readed submitting patches, and I am lazy when submitting > patches. But I've been working few months now _alone_ trying to make OpenWrt > on Raspberry Pi > a distribution that really works; instead of being broken, also, I have taken > steps to build a package feed for OpenWrt on Raspberry Pi that would make > OpenWrt a distribution > for rpi that would be on a same level with other available distributions > available for rpi.
While I understand the reasoning for your approach, it does not fit well into how OpenWrt's targets are organized. All targets using the same kernel branch are supposed to use the same kernel version, e.g. all targets using a 3.12 kernel are currently supposed to use 3.12.5. Then all patches from generic/patches-3.x are expected to be applied to the kernel, else things will break. Using a different kernel from the OpenWrt default version will eventually cause patches to not apply for either the odd target, or the others, because often patch will require modifications when going from 3.x.n to 3.x.n+1. Supporting both 3.x and 3.x.n+1 is not possible. Looking at your patch, I see you are modifying target/linux/generic/patches-3.12/880-gateworks_system_controller.patch, quite likely because it did not apply to your 3.12.7y. You likely broke the build for all other 3.12 targets with that. Therefore the only acceptable approach is to backport the appropriate changes from upstream and make them apply on top of the default OpenWrt 3.12 kernel. Since the current raspberry pi target BCM2708 will never be accepted upstream (it is there under a different name), a different approach would be to not backport the individual commits but rather use commit-diffs for the patches, or put the actual new files into files[-3.12] and only have patches that actually modify preexisting files (usually Makefile/Kconfig files). This would work as you don't have to worry about conflicts from upstream. Jonas _______________________________________________ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
