Hi,
On Mon, Jan 06, 2014 at 11:16:34PM +0100, Andreas Mohr wrote:
> Thus, while OpenWrt itself perhaps does not have much use for udev-based
> auto loading of modules (I guess modules usually are installed per-package,
> and then probably also registered for mechanical loading each),
> I'd deem the CONFIG_MODULE_STRIPPED setting to be
> (while not actively DANGEROUS) at least rather harmful.
> In light of this *default-enabled* functionality-breaking result
> the Kconfig descriptions of CONFIG_MODULE_STRIPPED:
> "Reduce module size"
> "Remove module parameter descriptions, author info, version, aliases,
> device tables, etc."
> as provided by e.g. ./target/linux/generic/patches-3.12/204-module_strip.patch
> seem to be rather very toned down.
>
> It would thus be nice to have this situation improved, perhaps by
> improving descriptions and possibly altering the default setting.
I created this RFC patch for the purpose of discussion about description
and proper implementation. For now I'm extending config setting info
only, foregoing a change of the config setting's defaults (perhaps
changing the often actively enabled default makes sense, but quite certainly
it's not up to me to decide that :).
- mark option as risky
- list details about what it might influence, and what its effects are
This RFC patch has been created against my currently active kernel
version only (3.10[.24])
- if positive I would be "willing" to support further kernel versions
(any comments on which ones?).
Perhaps the description currently is a bit too pessimizing - any
suggestions?
Thanks!
Andreas Mohr
diff --git a/target/linux/generic/patches-3.10/204-module_strip.patch
b/target/linux/generic/patches-3.10/204-module_strip.patch
index e4d5407..5abf191 100644
--- a/target/linux/generic/patches-3.10/204-module_strip.patch
+++ b/target/linux/generic/patches-3.10/204-module_strip.patch
@@ -99,17 +99,23 @@ Signed-off-by: Felix Fietkau <n...@openwrt.org>
--- a/init/Kconfig
+++ b/init/Kconfig
-@@ -1776,6 +1776,13 @@ config MODULE_SIG_HASH
+@@ -1776,6 +1776,19 @@ config MODULE_SIG_HASH
default "sha384" if MODULE_SIG_SHA384
default "sha512" if MODULE_SIG_SHA512
+config MODULE_STRIPPED
-+ bool "Reduce module size"
++ bool "Reduce module size: remove modinfo data (risky)"
+ depends on MODULES
+ help
+ Remove module parameter descriptions, author info, version, aliases,
+ device tables, etc.
+
++ This option removes modinfo data which people might consider important
++ (e.g. device aliases are crucial to provide driver <-> device
++ hotplug mapping for module auto-loading on certain environments -
++ i.e. this is endangering standard Linux upstream kernel integration
++ mechanisms, for a minor size gain of a reported few kB per rootfs).
++
endif # MODULES
config INIT_ALL_POSSIBLE
_______________________________________________
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
