2013.11.29. 23:53 keltezéssel, Martijn Zilverschoon írta:
> Once again this patch complains that it is corrupt, but for some
> reason the last line of the mbox file is missing.
> That seemed also be the case with other patches as well.
> 
> this command does do the trick however, sed in this case only adds a
> newline to the end of the file when it is missing.
> wget http://patchwork.openwrt.org/patch/4487/mbox/ -O - | sed '$a\' | git am 
> -s
> 
> 
> Maybe it is worth looking into, or maybe tell me what I do wrong?

I don't think that it is a patchwork issue because patches from other users are
fine usually. However I don't know how you are submitting the patches, so I
don't know what you are doing wrong. Maybe gmail causes the corruption.

Ideally you should send patches inline instead of attaching that to the mail
Additionally the Signed-off-by line should be part of the patch itself.

> because the other patch was submitted the same way and it doesn't have
> issues.

Your previous patches also had the missing last line issue, but I have fixed
those manually.

-Gabor
_______________________________________________
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel

Reply via email to