Shouldn't the patch be splitted because of different features? ( luci, non-luci stuff, hardware (huawai config))
> 1) support for Huawei E3672 dongle (initially no other dongles supported)
(from patch) huawei_e3276.gcom
Where is the typo here?
this patch adds ncm_xhr.js
> diff --git
> a/package/network/services/ncm/files/www/luci-static/resources/ncm_xhr.js
> b/package/network/services/ncm/files/www/luci-static/resources/ncm_xhr.js
> new file mode 100644
> index 0000000..c01e8ac
> --- /dev/null
> +++ b/package/network/services/ncm/files/www/luci-static/resources/ncm_xhr.js
however - there is already such file on my router
without ncm there
There are some whitespace errors:
git apply <4474-ncm-support.patch
<stdin>:576: trailing whitespace.
driver=$(echo "$cardinfo" | grep "driver '" | awk '{ gsub("\x27", "");
print $2; }')
<stdin>:658: trailing whitespace.
[ "$driver" == "-" ] ||
<stdin>:659: trailing whitespace.
[ -e "$device" ] &&
<stdin>:970: trailing whitespace.
luci.fs.access(table.concat({"/etc/gcom/ncm/carrier/",rv["driver"], ".gcom"},
"")) and
warning: 4 lines add whitespace errors.
smime.p7s
Description: S/MIME Cryptographic Signature
_______________________________________________ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
