On 2013-11-23 22:49, Bastian Bittorf wrote: > * Felix Fietkau <n...@openwrt.org> [23.11.2013 22:47]: >> > first update all hotplug-scripts to work without 'exit', then >> > change the /sbin/hotplug-call to '. $script' instead of ( . $script ) >> I disagree with the proposal to get rid of subshells here. I don't want >> one hotplug script to accidentally pick up variables of another one, >> because such issues can be annoying to debug, and a tiny >> micro-optimization of shell code simply isn't worth dealing with this. > > thanks for feedback - i understand your argument and agree. > beside that: anything against patch 1-5? No objections from me, except that I think 1 and 2 should be merged into one patch.
- Felix _______________________________________________ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
