Collectd, the backbone of Luci statistics module, has been recently updated already to 5.4.0, while Openwrt is still with 4.10.8.

5.0-5.4 branches have been released in 2011-2013 and the last Collectd release in August 2013 only contained 5.3 and 5.4.

Although 4.10.x is still marked as supported, it is said to be being "phased out" and no new commits have been made for a while.

My ar71xx/wndr3700 build has been using 5.2.1 since February (see http://patchwork.openwrt.org/patch/3299/ and http://patchwork.openwrt.org/patch/3300/ ).

I have now bumped up the version to 5.3.1 and have refreshed the needed patches.

I have compile-tested (with ar71xx) all collectd modules, and I have verified the real-life functionality of the following plugins: Conntrack, CPU/Processor, DNS, Interfaces, Memory, Netlink, Ping, Processes, TCP Connections, System Load, Uptime, Wireless.

The version bump requires changes both to collectd in the packages feed and to Luci sources, as some of the data items have changed name or file structure. Both need to be patched at the same time.

I am including two separate patches:
one for collectd in packages and one for luci-statistics in Luci trunk.

Explanation of main patches for collectd in packages feed:

- 140-fix-fqdnlookup.patch : FQDNLookup option has been turned on by default since 5.1. If that option is enabled, it causes collectd to refuse to start in a basic Openwrt box as typically a fully qualified domain name does not exist for the router. (That error related can only be properly seen when console is used to start collectd. Otherwise Luci statistics collectd simply dies immediately after starting it.) That option should be false by default. I included a new patch 140-fix-fqdnlookup.patch to turn the option off by default.
http://git.verplant.org/?p=collectd.git;a=commit;h=e58f85bb68b4c45130bb6fdf40b51db95d2b71e5

- quilt choked on some -Werror related patches, so I removed them from 003-remove-werror.patch.

- 120-fix_kernel_2.6.37.patch seems to be unnecessary as the file to be patched has been removed. Removed.

- 130-timeleft-max.patch is included upstream. I removed it.
http://git.verplant.org/?p=collectd.git;a=commitdiff;h=d5b09f2bb673ac9396da52b85bcbd16c98b3d633

- 105-rrdtool-csv-honor-datadir-531upstream.patch is needed to correct a rrd file path bug in 5.3.1. Already fixed in upstream.
http://git.verplant.org/?p=collectd.git;a=commit;h=6ef3385ccec835c7efae1ff3d5895858003a6da7

Regarding data presentation in Luci-statistics, there are three changes requiring patches to Luci feed:

-conntrack result data has changed name from "entropy" to "value".
-ping result data has changed name from "ping" to "value".
http://git.verplant.org/?p=collectd.git;a=commitdiff;h=77a6905147798210ec17173bd5e4410adcc3a112

-interface plugin has changed rrd data file structure so that the plugin instances (=interfaces) have separate data files. Luci needs to draw the graph for each plugin instance, not for each data instance. http://git.verplant.org/?p=collectd.git;a=commitdiff;h=cc3640ba512862cd5745446f1f1a997dd4344454

Signed-off-by: Hannu Nyman <hannu.ny...@iki.fi>
_______________________________________________
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel

Reply via email to