On Thursday 17 October 2013 16:12:27 Daniel Golle wrote:
> Hi Sven,
>
> thank you for addressing that issue!
>
> On 10/17/2013 06:42 PM, Sven Eckelmann wrote:
> > diff --git a/target/linux/ar71xx/base-files/lib/upgrade/allnet.sh
> > b/target/linux/ar71xx/base-files/lib/upgrade/allnet.sh index
> > 9a375ff..8076fbd 100644
> > --- a/target/linux/ar71xx/base-files/lib/upgrade/allnet.sh
> > +++ b/target/linux/ar71xx/base-files/lib/upgrade/allnet.sh
> > @@ -7,6 +7,7 @@
> >
> > platform_add_ramfs_ubootenv() {
> >
> > [ -e /usr/sbin/fw_printenv ] && install_bin /usr/sbin/fw_printenv
> > /usr/sbin/fw_setenv [ -e /etc/fw_env.config ] && install_file
> > /etc/fw_env.config
> >
> > + [ -e /bin/mkdir ] && install_bin /bin/mkdir /bin/mkdir
>
> mkdir is a link to busybox. wouldn't it be better to just add that symlink
> to the list of busybox symlinks in
> /package/base-files/files/lib/upgrade/common.sh
> or even better: why not just
> mkdir -p $RAM_ROOT/var/lock
> and not even use mkdir inside the ramdisk?
Yes, you are right. It is easier and still obvious for the reader. See v2 of
the patch.
Kind regards,
Sven
signature.asc
Description: This is a digitally signed message part.
_______________________________________________ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
