Hi, ----- Mail original ----- > De: "Felix Fietkau" <n...@openwrt.org> > À: "OpenWrt Development List" <openwrt-devel@lists.openwrt.org> > Cc: "Sujith Manoharan" <c_man...@qca.qualcomm.com>, "Luis R. Rodriguez" > <mcg...@qca.qualcomm.com> > Envoyé: Mardi 8 Octobre 2013 13:05:49 > Objet: Re: [OpenWrt-Devel] [PATCH 5/7] hostapd: prompt user confirmation when > WPS is used with hiden ssid > > On 2013-09-10 2:16 AM, Luis R. Rodriguez wrote: > > From: Mathieu Olivari <math...@qca.qualcomm.com> > > > > This is required explicitly for WPS 2.0 testing. > > > > Signed-off-by: Mathieu Olivari <math...@qca.qualcomm.com> > > Signed-off-by: Sujith Manoharan <c_man...@qca.qualcomm.com> > > Signed-off-by: Luis R. Rodriguez <mcg...@qca.qualcomm.com> > NACK. You should not assume that /sbin/wifi is called interactively. > It > is frequently called by scripts, and this patch could cause nasty > script > hangs. > > - Felix
i've tested when the patch was submitted and read -s -n 1 is intelligent enough to detect that there is no stdin and not hang I don't know if it's always true (true for busybox read) Regards Etienne _______________________________________________ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
