Jo-Philipp Wich <j...@openwrt.org> writes: > NACK to this patch, comments below. > >> -set network.lan.ip6assign='60' >> +set network.lan.ip6assign='64' > > Cosmetical change, not needed. If less than a /60 is available, it will > use less.
As far as I can tell the logic here is broken. What does it mean to assign something less more than a /64 to an interface? The standard interface assignment on a ipv6 interface is a /64. My assumption was this was a broken conversion from a wide-dhcp configuration. >> -set network.wan6='interface' >> -set network.wan6.ifname='@wan' >> +set network.wan6='alias' >> +set network.wan6.interface='wan' > > Those are exactly equivalent, in fact you're replacing the current alias > notation with the deprecated one. No they aren't equivalent the alias syntax works. The new stuff does not. The solution may be to fix the new alias syntax but as of when I sent this patch the code simply did not work. openwrt choked on this configuration until I changed it away from the ``new'' syntax that doesn't work. >> +set network.wan6.reqprefix='60' > > That's probably the only actual required change, please retest with only > this. Already tested, before I sent this patch. Eric _______________________________________________ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
